TLS related fixes#38
Open
splitbrain wants to merge 2 commits into
Open
Conversation
The protocol check in send() used a bitwise | between the last two comparisons instead of ||. It happened to produce the correct result, but was a typo. Use || for clarity and to avoid surprising edge cases.
- connect(): include the OS error code/message from stream_socket_client() so failures report 'Connection refused', 'Connection timed out', etc. instead of the uninformative 'Could not open SMTP Port'. - starttls(): suppress the misleading PHP warning from stream_socket_enable_crypto() (often 'SSL: Success') and append the real OpenSSL reason from error_get_last() to the CryptoException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a logic error when checking the TLS settings and makes error messages in exceptions more helpful by keeping the original error. It also suppresses a warning before throwing the exception.